netdev - Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200507163531.GA2100062@kroah.com>
Date:   Thu, 7 May 2020 18:35:31 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     "Saleem, Shiraz" <shiraz.saleem@...el.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Ertman, David M" <david.m.ertman@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "ranjani.sridharan@...ux.intel.com" 
        <ranjani.sridharan@...ux.intel.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "Bowers, AndrewX" <andrewx.bowers@...el.com>,
        Martin Habets <mhabets@...arflare.com>
Subject: Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA

On Thu, May 07, 2020 at 04:24:32PM +0100, Edward Cree wrote:
> On 07/05/2020 16:06, Greg KH wrote:
> > I can't accept that this series is using a virtual bus properly without
> > actually using the virtual bus driver code, can you?
> I might be misunderstanding, but I *think* a hardware driver likeice is
>  the 'provider' of a virtbus, and it's only 'consumers' of it (like an
>  RDMA device talking to that ice instance) that are virtbus_drivers.
> Though tbh I'm not entirely happy either with a series that adds the
>  provider side but not any users... and either way, the documentation
>  *really* doesn't make it clear whether it works the way I think it does
>  or not.

Exactly, I can't tell anything from the documentation at all, so I
looked at how the code was used.  That just made things worse...

This needs more work.

greg k-h