netdev - Re: [Patch net v2] net: fix a potential recursive NETDEV_FEAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXMZ1u+a+c1eNFThYar4eDFVs2G2F7otHHPK-zye+vzww@mail.gmail.com>
Date:   Thu, 7 May 2020 11:45:37 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        syzbot <syzbot+e73ceacfd8560cc8a3ca@...kaller.appspotmail.com>,
        syzbot+c2fb6f9ddcea95ba49b5@...kaller.appspotmail.com,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Jann Horn <jannh@...gle.com>
Subject: Re: [Patch net v2] net: fix a potential recursive NETDEV_FEAT_CHANGE

On Wed, May 6, 2020 at 1:31 PM Nikolay Aleksandrov
<nikolay@...ulusnetworks.com> wrote:
> The patch looks good, but note that __netdev_update_features() used to return -1
> before the commit in the Fixes tag above (between 6cb6a27c45ce and 00ee59271777).
> It only restored that behaviour.

Good point! But commit fd867d51f889 is the one which started
using netdev_update_features() in netdev_sync_lower_features(),
your commits 00ee59271777 and 17b85d29e82c are both after it,
and returning whatever doesn't matter before commit fd867d51f889,
therefore, commit fd867d51f889 is the right one to blame?

I will send V3 to just update this Fixes tag.

Thanks!