netdev - Re: [PATCH net-next] net: remove newlines in NL_SET_ERR_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200507.175630.494283287134243359.davem@davemloft.net>
Date:   Thu, 07 May 2020 17:56:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jacob.e.keller@...el.com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, apw@...onical.com,
        joe@...ches.com
Subject: Re: [PATCH net-next] net: remove newlines in NL_SET_ERR_MSG_MOD

From: Jacob Keller <jacob.e.keller@...el.com>
Date: Wed,  6 May 2020 17:58:27 -0700

> The NL_SET_ERR_MSG_MOD macro is used to report a string describing an
> error message to userspace via the netlink extended ACK structure. It
> should not have a trailing newline.
> 
> Add a cocci script which catches cases where the newline marker is
> present. Using this script, fix the handful of cases which accidentally
> included a trailing new line.
> 
> I couldn't figure out a way to get a patch mode working, so this script
> only implements context, report, and org.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>

Applied, thank you.