netdev - Re: [PATCH -next] brcmfmac: make non-global functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97fd043c-bf60-b2c3-b901-f57d7fa957be@cypress.com>
Date:   Fri, 8 May 2020 21:31:58 +0800
From:   Wright Feng <wright.feng@...ress.com>
To:     Chen Zhou <chenzhou10@...wei.com>, kvalo@...eaurora.org
Cc:     arend.vanspriel@...adcom.com, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, chi-hsien.lin@...ress.com,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        brcm80211-dev-list@...ress.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] brcmfmac: make non-global functions static



Chen Zhou 於 5/8/2020 9:32 AM 寫道:
> Fix sparse warning:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5:
> 	warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
Reviewed-by: Wright Feng <wright.feng@...ress.com>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> index e32c24a2670d..2a2440031357 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> @@ -2203,7 +2203,7 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struct brcmf_p2p_info *p2p,
>   	return ERR_PTR(err);
>   }
>   
> -int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
> +static int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
>   {
>   	int i;
>   	struct brcmf_if *ifp = netdev_priv(cfg_to_ndev(cfg));
>