netdev - Re: [PATCH v3] net: tcp: fix rx timestamp behavior for tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSApvaWRxgx_Q1ku=vXbArZc5EJHWhLhCQbzH0+-R3Pzmcf+A@mail.gmail.com>
Date:   Fri, 8 May 2020 10:56:42 -0400
From:   Soheil Hassas Yeganeh <soheil@...gle.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Kelly Littlepage <kelly@...chronos.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, iris@...chronos.com,
        kuba@...nel.org, kuznet@....inr.ac.ru,
        Mike Maloney <maloney@...gle.com>,
        netdev <netdev@...r.kernel.org>, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH v3] net: tcp: fix rx timestamp behavior for tcp_recvmsg

On Fri, May 8, 2020 at 10:45 AM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
>
>
> On 5/8/20 7:23 AM, Kelly Littlepage wrote:
> > The stated intent of the original commit is to is to "return the timestamp
> > corresponding to the highest sequence number data returned." The current
> > implementation returns the timestamp for the last byte of the last fully
> > read skb, which is not necessarily the last byte in the recv buffer. This
> > patch converts behavior to the original definition, and to the behavior of
> > the previous draft versions of commit 98aaa913b4ed ("tcp: Extend
> > SOF_TIMESTAMPING_RX_SOFTWARE to TCP recvmsg") which also match this
> > behavior.
> >
> > Fixes: 98aaa913b4ed ("tcp: Extend SOF_TIMESTAMPING_RX_SOFTWARE to TCP recvmsg")
> > Co-developed-by: Iris Liu <iris@...chronos.com>
> > Signed-off-by: Iris Liu <iris@...chronos.com>
> > Signed-off-by: Kelly Littlepage <kelly@...chronos.com>
> > ---
> > Reverted to the original subject line
>
>
> SGTM, thanks.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>