netdev - Re: [PATCH net] mptcp: set correct vfs info for subflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 07 May 2020 18:16:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, mathew.j.martineau@...ux.intel.com,
        kuba@...nel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: set correct vfs info for subflows

From: Paolo Abeni <pabeni@...hat.com>
Date: Thu,  7 May 2020 18:53:24 +0200

> When a subflow is created via mptcp_subflow_create_socket(),
> a new 'struct socket' is allocated, with a new i_ino value.
> 
> When inspecting TCP sockets via the procfs and or the diag
> interface, the above ones are not related to the process owning
> the MPTCP master socket, even if they are a logical part of it
> ('ss -p' shows an empty process field)
> 
> Additionally, subflows created by the path manager get
> the uid/gid from the running workqueue.
> 
> Subflows are part of the owning MPTCP master socket, let's
> adjust the vfs info to reflect this.
> 
> After this patch, 'ss' correctly displays subflows as belonging
> to the msk socket creator.
> 
> Fixes: 2303f994b3e1 ("mptcp: Associate MPTCP context with TCP socket")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied and queued up for -stable, thanks.