netdev - Re: [PATCH net-next v3 07/33] xdp: xdp_frame add member frame_sz and handle in convert_to_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200508090054.14138b79@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 8 May 2020 09:00:54 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     sameehj@...zon.com, netdev@...r.kernel.org, bpf@...r.kernel.org,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        John Fastabend <john.fastabend@...il.com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        David Ahern <dsahern@...il.com>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [PATCH net-next v3 07/33] xdp: xdp_frame add member frame_sz
 and handle in convert_to_xdp_frame

On Fri, 08 May 2020 13:09:21 +0200 Jesper Dangaard Brouer wrote:
> +/* Used by XDP_WARN macro, to avoid inlining WARN() in fast-path */
> +void xdp_warn(const char* msg, const char* func, const int line) {
> +	WARN(1, "XDP_WARN: %s(line:%d): %s\n", func, line, msg);
> +};
> +EXPORT_SYMBOL_GPL(xdp_warn);

ERROR: "foo* bar" should be "foo *bar"
#59: FILE: include/net/xdp.h:109:
+void xdp_warn(const char* msg, const char* func, const int line);

ERROR: "foo* bar" should be "foo *bar"
#59: FILE: include/net/xdp.h:109:
+void xdp_warn(const char* msg, const char* func, const int line);

ERROR: "foo* bar" should be "foo *bar"
#104: FILE: net/core/xdp.c:502:
+void xdp_warn(const char* msg, const char* func, const int line) {

ERROR: "foo* bar" should be "foo *bar"
#104: FILE: net/core/xdp.c:502:
+void xdp_warn(const char* msg, const char* func, const int line) {

ERROR: open brace '{' following function definitions go on the next line
#104: FILE: net/core/xdp.c:502:
+void xdp_warn(const char* msg, const char* func, const int line) {