netdev - Re: [PATCH net-next 7/7] net: atlantic: unify get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d509d2cb-0402-8053-7e9e-99bff970b11f@marvell.com>
Date:   Fri, 8 May 2020 19:48:05 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        "Mark Starovoytov" <mstarovoitov@...vell.com>
Subject: Re: [PATCH net-next 7/7] net: atlantic: unify get_mac_permanent


>> Thats why the logic below randomizes only low three octets.
> 
> Are there any other drivers in tree which do that? I think the standard
> operating procedure is:
> 
> if (!valid) {
> 	netdev_warn(dev, "Invalid MAC using random\n");
> 	eth_hw_addr_random(dev);
> }
> 
> Please see all the eth_hw_addr_random() calls in drivers.

You are right indeed. Sorry I somehow overlooked this sequence in other device
drivers. Agree, its better to unify behavior then.

Thanks,
  Igor