netdev - Re: [PATCH bpf-next 3/3] selftest/bpf: add BPF triggring benchmark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZoMZNADA6-_4CUtV+YuBWeuNF9EqDT-SbUNhOMmw_uTQ@mail.gmail.com>
Date:   Fri, 8 May 2020 10:50:07 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <ast@...com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next 3/3] selftest/bpf: add BPF triggring benchmark

On Fri, May 8, 2020 at 9:40 AM Alexei Starovoitov <ast@...com> wrote:
>
> On 5/8/20 12:05 AM, Andrii Nakryiko wrote:
> >
> > base      :    9.200 ± 0.319M/s
> > fentry    :    8.955 ± 0.241M/s
>
> > +SEC("fentry/__x64_sys_getpgid")
> > +int bench_trigger_fentry(void *ctx)
> > +{
> > +     __sync_add_and_fetch(&hits, 1);
> > +     return 0;
> > +}
>
> adding 'lock xadd' is not cheap.
> I wonder how much of the delta come from it and from the rest of
> trampoline.

Yeah, could be, though count-global/count-local benchmarks get to
150Mops/s under no-sharing scenario, so effect shouldn't be that high.
Well, in any case, 9Mops/s is more than enough for my cases :)