netdev - Re: [PATCH net-next v8 2/3] xen networking: add XDP offset adjustment to xen-netback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200508140742.351772c3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 8 May 2020 14:07:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Denis Kirjanov <kda@...ux-powerpc.org>
Cc:     netdev@...r.kernel.org, brouer@...hat.com, jgross@...e.com,
        wei.liu@...nel.org, paul@....org, ilias.apalodimas@...aro.org
Subject: Re: [PATCH net-next v8 2/3] xen networking: add XDP offset
 adjustment to xen-netback

On Thu,  7 May 2020 15:40:40 +0300 Denis Kirjanov wrote:
> +static inline int xenvif_rx_xdp_offset(struct xenvif *vif)

Please don't use static inlines in C files, compiler will know when to
inline and when not. 

> +{
> +	return vif->xdp_enabled ? XDP_PACKET_HEADROOM : 0;
> +}