netdev - Re: [PATCH v4] net: tcp: fix rx timestamp behavior for tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200508161735.5ca945c0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 8 May 2020 16:17:35 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kelly Littlepage <kelly@...ttlepage.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, iris@...chronos.com,
        kelly@...chronos.com, kuznet@....inr.ac.ru, maloney@...gle.com,
        netdev@...r.kernel.org, soheil@...gle.com,
        willemdebruijn.kernel@...il.com, yoshfuji@...ux-ipv6.org,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH v4] net: tcp: fix rx timestamp behavior for tcp_recvmsg

On Fri,  8 May 2020 19:58:46 +0000 Kelly Littlepage wrote:
> From: Kelly Littlepage <kelly@...chronos.com>
> 
> The stated intent of the original commit is to is to "return the timestamp
> corresponding to the highest sequence number data returned." The current
> implementation returns the timestamp for the last byte of the last fully
> read skb, which is not necessarily the last byte in the recv buffer. This
> patch converts behavior to the original definition, and to the behavior of
> the previous draft versions of commit 98aaa913b4ed ("tcp: Extend
> SOF_TIMESTAMPING_RX_SOFTWARE to TCP recvmsg") which also match this
> behavior.

Applied, thank you!