netdev - Re: [PATCH v3 4/5] ksz: Add Microchip KSZ8863 SMI/SPI based driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 May 2020 18:56:56 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com, davem@...emloft.net,
        kernel@...gutronix.de
Subject: Re: [PATCH v3 4/5] ksz: Add Microchip KSZ8863 SMI/SPI based driver
 support

On Fri, May 08, 2020 at 05:43:42PM +0200, Michael Grzeschik wrote:
> Add KSZ88X3 driver support. We add support for the KXZ88X3 three port
> switches using the Microchip SMI Interface. They are currently only
> supported using the MDIO-Bitbang Interface. Which is making use of the
> mdio_ll_read/write functions. The patch uses the common functions
> from the ksz8795 driver.

This patch is pretty hard to review. It is huge, and making multiple
changes all at once.

Please break it up into a number of smaller changes.

       Andrew