[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ebac4532-6dae-5609-9629-ba10197671c3@gmail.com>
Date: Sat, 9 May 2020 10:12:52 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: netdev <netdev@...r.kernel.org>,
Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
Stefan Wahren <wahrenst@....net>,
Marek Szyprowski <m.szyprowski@...sung.com>,
"David S. Miller" <davem@...emloft.net>,
Thomas Gleixner <tglx@...utronix.de>,
Tal Gilboa <talgi@...lanox.com>,
Michael Chan <michael.chan@...adcom.com>,
Andy Gospodarek <gospo@...adcom.com>,
Randy Dunlap <rdunlap@...radead.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: broadcom: Imply BROADCOM_PHY for BCMGENET
On 5/9/2020 12:38 AM, Geert Uytterhoeven wrote:
> Hi Florian,
>
> Thanks for your patch!
>
> On Sat, May 9, 2020 at 12:32 AM Florian Fainelli <f.fainelli@...il.com> wrote:
>> The GENET controller on the Raspberry Pi 4 (2711) is typically
>> interfaced with an external Broadcom PHY via a RGMII electrical
>> interface. To make sure that delays are properly configured at the PHY
>> side, ensure that we get a chance to have the dedicated Broadcom PHY
>> driver (CONFIG_BROADCOM_PHY) enabled for this to happen.
>
> I guess it can be interfaced to a different external PHY, too?
Yes, although this has not happened yet to the best of my knowledge.
>
>> Fixes: 402482a6a78e ("net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed")
>> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>
>> --- a/drivers/net/ethernet/broadcom/Kconfig
>> +++ b/drivers/net/ethernet/broadcom/Kconfig
>> @@ -69,6 +69,7 @@ config BCMGENET
>> select BCM7XXX_PHY
>> select MDIO_BCM_UNIMAC
>> select DIMLIB
>> + imply BROADCOM_PHY if ARCH_BCM2835
>
> Which means support for the BROADCOM_PHY is always included
> on ARCH_BCM2835, even if a different PHY is used?
It is included by default on and can be deselected if needed, which is
exactly what we want here, a sane default, but without the inflexibility
of "select".
>
>> help
>> This driver supports the built-in Ethernet MACs found in the
>> Broadcom BCM7xxx Set Top Box family chipset.
>
> Gr{oetje,eeting}s,
>
> Geert
>
--
Florian
Powered by blists - more mailing lists