lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 May 2020 18:54:02 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Christophe JAILLET <christophe.jaillet@...adoo.fr> Cc: davem@...emloft.net, fthain@...egraphics.com.au, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] net/sonic: Fix some resource leaks in error handling paths On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote: > @@ -527,8 +531,9 @@ static int mac_sonic_platform_remove(struct platform_device *pdev) > struct sonic_local* lp = netdev_priv(dev); > > unregister_netdev(dev); > - dma_free_coherent(lp->device, SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode), > - lp->descriptors, lp->descriptors_laddr); > + dma_free_coherent(lp->device, > + SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode), > + lp->descriptors, lp->descriptors_laddr); > free_netdev(dev); > > return 0; This is a white-space only change, right? Since this is a fix we should avoid making cleanups which are not strictly necessary.
Powered by blists - more mailing lists