netdev - Re: [PATCH v3 1/5] net: phy: Add support for microchip SMI0 MDIO bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200509192549.GB338317@lunn.ch>
Date:   Sat, 9 May 2020 21:25:49 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Michael Grzeschik <m.grzeschik@...gutronix.de>,
        netdev@...r.kernel.org, davem@...emloft.net, kernel@...gutronix.de
Subject: Re: [PATCH v3 1/5] net: phy: Add support for microchip SMI0 MDIO bus

> > -		mdiobb_cmd(ctrl, MDIO_WRITE, phy, reg);
> > +		mdiobb_cmd(ctrl, ctrl->op_c22_write, phy, reg);
> 
> There are other users of the mdio-bitbang.c file which I believe you are
> going to break here because they will not initialize op_c22_write or
> op_c22_read, and thus they will be using 0, instead of MDIO_READ and
> MDIO_WRITE. I believe you need something like the patch attached.

Ah, totally missed that:

https://elixir.bootlin.com/linux/latest/source/arch/powerpc/platforms/82xx/ep8248e.c#L98
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/8390/ax88796.c#L444
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c#L103
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/renesas/ravb_main.c#L165
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/renesas/sh_eth.c#L1257

	Andrew