netdev - Re: [PATCH net-next v1] hinic: add three net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200508201004.0e2dc608@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 8 May 2020 20:10:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "luobin (L)" <luobin9@...wei.com>
Cc:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <luoxianjun@...wei.com>,
        <yin.yinshi@...wei.com>, <cloud.wangxiaoyun@...wei.com>
Subject: Re: [PATCH net-next v1] hinic: add three net_device_ops of vf

On Sat, 9 May 2020 10:56:55 +0800 luobin (L) wrote:
> >> -	if (!HINIC_IS_VF(nic_dev->hwdev->hwif))
> >> -		/* Wait up to 3 sec between port enable to link state */
> >> -		msleep(3000);  
> > Why is this no longer needed?
> > ---When phsical port links up, hw will notify this event to hinic driver.Driver code can  
> 
> handle this event now, so need to wait for link up in hinic_open().

Makes sense.