lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 May 2020 04:35:39 +0000 From: Luis Chamberlain <mcgrof@...nel.org> To: jeyu@...nel.org Cc: akpm@...ux-foundation.org, arnd@...db.de, rostedt@...dmis.org, mingo@...hat.com, aquini@...hat.com, cai@....pw, dyoung@...hat.com, bhe@...hat.com, peterz@...radead.org, tglx@...utronix.de, gpiccoli@...onical.com, pmladek@...e.com, tiwai@...e.de, schlad@...e.de, andriy.shevchenko@...ux.intel.com, keescook@...omium.org, daniel.vetter@...ll.ch, will@...nel.org, mchehab+samsung@...nel.org, kvalo@...eaurora.org, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>, "Michael S. Tsirkin" <mst@...hat.com>, Shannon Nelson <snelson@...sando.io>, Jakub Kicinski <kuba@...nel.org>, Heiner Kallweit <hkallweit1@...il.com> Subject: [PATCH 02/15] ethernet/839: use new module_firmware_crashed() This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: "Michael S. Tsirkin" <mst@...hat.com> Cc: Shannon Nelson <snelson@...sando.io> Cc: Jakub Kicinski <kuba@...nel.org> Cc: Heiner Kallweit <hkallweit1@...il.com> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org> --- drivers/net/ethernet/8390/axnet_cs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/8390/axnet_cs.c b/drivers/net/ethernet/8390/axnet_cs.c index aeae7966a082..8ad0200db8e9 100644 --- a/drivers/net/ethernet/8390/axnet_cs.c +++ b/drivers/net/ethernet/8390/axnet_cs.c @@ -1358,9 +1358,11 @@ static void ei_receive(struct net_device *dev) */ if ((netif_msg_rx_err(ei_local)) && this_frame != ei_local->current_page && - (this_frame != 0x0 || rxing_page != 0xFF)) + (this_frame != 0x0 || rxing_page != 0xFF)) { + module_firmware_crashed(); netdev_err(dev, "mismatched read page pointers %2x vs %2x\n", this_frame, ei_local->current_page); + } if (this_frame == rxing_page) /* Read all the frames? */ break; /* Done for now */ -- 2.25.1
Powered by blists - more mailing lists