[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <b7651b26-ac1e-6281-efb2-7eff0018b158@web.de>
Date: Sat, 9 May 2020 08:15:18 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Christophe Jaillet <christophe.jaillet@...adoo.fr>,
netdev@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Finn Thain <fthain@...egraphics.com.au>,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] net/sonic: Fix some resource leaks in error handling
paths
> While at it, rename a label in order to be slightly more informative and
> split some too long lines.
Would you like to add the tag “Fixes” to the change description?
…
> +++ b/drivers/net/ethernet/natsemi/macsonic.c
> @@ -506,10 +506,14 @@ static int mac_sonic_platform_probe(struct platform_device *pdev)
>
> err = register_netdev(dev);
> if (err)
> - goto out;
> + goto undo_probe1;
>
> return 0;
>
> +undo_probe1:
> + dma_free_coherent(lp->device,
> + SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode),
> + lp->descriptors, lp->descriptors_laddr);
> out:
…
How do you think about the possibility to use the label “free_dma”?
Regards,
Markus
Powered by blists - more mailing lists