netdev - Re: [PATCH] bpfilter: document build requirements for bpfilter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAT2xMR9fq+bJCc=1wLuEM99fPNagDc=NkFoDKNi-YCpDg@mail.gmail.com>
Date:   Sat, 9 May 2020 16:51:00 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Valdis Klētnieks <valdis.kletnieks@...edu>
Cc:     Sam Ravnborg <sam@...nborg.org>,
        "David S. Miller" <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpfilter: document build requirements for bpfilter_umh

On Sat, May 9, 2020 at 1:47 PM Valdis Klētnieks <valdis.kletnieks@...edu> wrote:
>
> It's not intuitively obvious that bpfilter_umh is a statically linked binary.
> Mention the toolchain requirement in the Kconfig help, so people
> have an easier time figuring out what's needed.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>
>

Applied to linux-kbuild.
Thanks.


> diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig
> index fed9290e3b41..0ec6c7958c20 100644
> --- a/net/bpfilter/Kconfig
> +++ b/net/bpfilter/Kconfig
> @@ -13,4 +13,8 @@ config BPFILTER_UMH
>         default m
>         help
>           This builds bpfilter kernel module with embedded user mode helper
> +
> +         Note: your toolchain must support building static binaries, since
> +         rootfs isn't mounted at the time when __init functions are called
> +         and do_execv won't be able to find the elf interpreter.
>  endif
>


-- 
Best Regards
Masahiro Yamada