lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 10 May 2020 23:46:27 +0200
From:   Pablo Neira Ayuso <>
To:     Dan Carpenter <>
Cc:     Jozsef Kadlecsik <>,
        Florian Westphal <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,,,,
Subject: Re: [PATCH net] netfilter: nf_conntrack_pptp: prevent buffer
 overflows in debug code

Hi Dan,

On Wed, May 06, 2020 at 01:17:53PM +0300, Dan Carpenter wrote:
> Smatch complains that the value for "cmd" comes from the network and
> can't be trusted.  The value is actually checked at the end of these
> functions so I just copied that here as well.

I'm attaching another patch, it's based on yours.

It's basically adding a pptp_msg_name() helper function, which is
probably what should have been done in this code since the beginning.

There are many of msg <= PPTP_MSG_MAX ? pptp_msg_name[msg] :

Thank you.

View attachment "dan.patch" of type "text/x-diff" (6558 bytes)

Powered by blists - more mailing lists