lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 10 May 2020 07:30:50 +0200
From:   Markus Elfring <>
To:     Finn Thain <>,
        Christophe Jaillet <>,
        "David S. Miller" <>,
        Jakub Kicinski <>
Subject: Re: [PATCH] net/sonic: Fix some resource leaks in error handling

> Is there a way to add a Fixes tag that would not invoke the -stable
> process? And was that what you had in mind?

Christophe Jaillet proposed to complete the exception handling also for this
function implementation.
I find that such a software correction is qualified for this tag.

Corresponding consequences can vary then according to the change management
of involved developers.

> I think 'undo_probe1' is both descriptive and consistent with commit
> 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling path in
> 'jazz_sonic_probe()'").

I can agree to this view (in principle).

By the way:
The referenced commit contains the tag “Fixes”.

> Your suggestion, 'free_dma' is also good.

Thanks for your positive feedback.

> But coming up with good alternatives is easy.

But the change acceptance can occasionally become harder.

> If every good alternative would be considered there would be no obvious way
> to get a patch merged.

I imagine that some alternatives can result in preferable solutions, can't they?


Powered by blists - more mailing lists