lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 May 2020 11:07:18 +0200 From: Markus Elfring <Markus.Elfring@....de> To: Finn Thain <fthain@...egraphics.com.au>, Christophe Jaillet <christophe.jaillet@...adoo.fr>, netdev@...r.kernel.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Subject: Re: net/sonic: Fix some resource leaks in error handling paths >> https://lore.kernel.org/lkml/20200427061803.53857-1-christophe.jaillet@wanadoo.fr/ > > Do you know when these bugs were introduced? I suggest to take another look at a provided tag “Fixes”. To which commit would you like to refer to for the proposed adjustment of the function “mac_sonic_platform_probe”? > Naming goto labels is just painting another bikeshed. Yes, some > alternatives are preferable but it takes too long to identify them and > finding consensus is unlikely anyway, as it's a matter of taste. Would you find numbered labels unwanted according to a possible interpretation related to “GW-BASIC” identifier selection? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=e99332e7b4cda6e60f5b5916cf9943a79dbef902#n460 Can programming preferences evolve into the direction of “say what the goto does”? Regards, Markus
Powered by blists - more mailing lists