lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 May 2020 17:12:26 +0200 From: Michal Kubecek <mkubecek@...e.cz> To: netdev@...r.kernel.org Cc: Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Chris Healy <cphealy@...il.com>, michael@...le.cc Subject: Re: [PATCH net-next v3 06/10] net: ethtool: Add infrastructure for reporting cable test results On Sat, May 09, 2020 at 06:28:47PM +0200, Andrew Lunn wrote: > Provide infrastructure for PHY drivers to report the cable test > results. A netlink skb is associated to the phydev. Helpers will be > added which can add results to this skb. Once the test has finished > the results are sent to user space. > > When netlink ethtool is not part of the kernel configuration stubs are > provided. It is also impossible to trigger a cable test, so the error > code returned by the alloc function is of no consequence. > > v2: > Include the status complete in the netlink notification message > > Signed-off-by: Andrew Lunn <andrew@...n.ch> Reviewed-by: Michal Kubecek <mkubecek@...e.cz> It seems you applied the changes to ethnl_cable_test_alloc() suggested in v2 review as part of patch 7 rather than here. I don't think it's necessary to fix that unless there is some actual problem that would require a resubmit. Michal
Powered by blists - more mailing lists