netdev - Re: [PATCH net-next v3 06/10] net: ethtool: Add infrastructure for reporting cable test results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200510113947.567e07a5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 10 May 2020 11:39:47 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Michal Kubecek <mkubecek@...e.cz>, netdev@...r.kernel.org,
        David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Chris Healy <cphealy@...il.com>, michael@...le.cc
Subject: Re: [PATCH net-next v3 06/10] net: ethtool: Add infrastructure for
 reporting cable test results

On Sun, 10 May 2020 20:22:52 +0200 Andrew Lunn wrote:
> > Sorry Andrew, would you mind doing one more quick spin? :(  
> 
> No problem.

Thanks!

> > More importantly we should not use the ENOTSUPP error code, AFAIU it's
> > for NFS, it's not a standard error code and user space struggles to
> > translate it with strerror(). Would you mind replacing all ENOTSUPPs
> > with EOPNOTSUPPs?  
> 
> O.K.
> 
> Would it be worth getting checkpatch warning about this?

Good point. I feel like I already had a patch for it once, it must have
gotten lost when I was changing jobs. I'll take care of it.