netdev - Re: net: phylink: supported modes set to 0 with genphy sfp module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200511182954.GV1551@shell.armlinux.org.uk>
Date:   Mon, 11 May 2020 19:29:54 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Julien Beraud <julien.beraud@...lia.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: net: phylink: supported modes set to 0 with genphy sfp module

On Mon, May 11, 2020 at 05:45:02PM +0200, Julien Beraud wrote:
> Following commit:
> 
> commit 52c956003a9d5bcae1f445f9dfd42b624adb6e87
> Author: Russell King <rmk+kernel@...linux.org.uk>
> Date:   Wed Dec 11 10:56:45 2019 +0000
> 
>     net: phylink: delay MAC configuration for copper SFP modules
> 
> 
> In function phylink_sfp_connect_phy, phylink_sfp_config is called before
> phylink_attach_phy.
> 
> In the case of a genphy, the "supported" field of the phy_device is filled
> by:
> phylink_attach_phy->phy_attach_direct->phy_probe->genphy_read_abilities.
> 
> It means that:
> 
> ret = phylink_sfp_config(pl, mode, phy->supported, phy->advertising);
> will have phy->supported with no bits set, and then the first call to
> phylink_validate in phylink_sfp_config will return an error:
> 
> return phylink_is_empty_linkmode(supported) ? -EINVAL : 0;
> 
> this results in putting the sfp driver in "failed" state.

Which PHY is this?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up