netdev - Re: [PATCH net-next 3/4] net: dsa: tag_ocelot: use a short prefix on both ingress and egress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200511.161105.2010361750917771255.davem@davemloft.net>
Date:   Mon, 11 May 2020 16:11:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     kuba@...nel.org, andrew@...n.ch, f.fainelli@...il.com,
        vivien.didelot@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/4] net: dsa: tag_ocelot: use a short prefix
 on both ingress and egress

From: Vladimir Oltean <olteanv@...il.com>
Date: Tue, 12 May 2020 01:44:53 +0300

> On Tue, 12 May 2020 at 01:40, Jakub Kicinski <kuba@...nel.org> wrote:
>>
>> On Mon, 11 May 2020 23:20:45 +0300 Vladimir Oltean wrote:
>> > From: Vladimir Oltean <vladimir.oltean@....com>
>> >
>> > There are 2 goals that we follow:
>> >
>> > - Reduce the header size
>> > - Make the header size equal between RX and TX
>>
>> Getting this from sparse:
>>
>> ../net/dsa/tag_ocelot.c:185:17: warning: incorrect type in assignment (different base types)
>> ../net/dsa/tag_ocelot.c:185:17:    expected unsigned int [usertype]
>> ../net/dsa/tag_ocelot.c:185:17:    got restricted __be32 [usertype]
> 
> I hate this warning :(

You hate that endianness bugs are caught automatically? :-)