netdev - Re: [PATCH net-next 3/4] net: dsa: tag_ocelot: use a short prefix on both ingress and egress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hrxjjhNBJfxVKAZ2CO3=6=Mb3Za=8BjKia4k=w=MXtZVg@mail.gmail.com>
Date:   Tue, 12 May 2020 02:19:15 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 3/4] net: dsa: tag_ocelot: use a short prefix on
 both ingress and egress

On Tue, 12 May 2020 at 02:11, David Miller <davem@...emloft.net> wrote:
>
> From: Vladimir Oltean <olteanv@...il.com>
> Date: Tue, 12 May 2020 01:44:53 +0300
>
> > On Tue, 12 May 2020 at 01:40, Jakub Kicinski <kuba@...nel.org> wrote:
> >>
> >> On Mon, 11 May 2020 23:20:45 +0300 Vladimir Oltean wrote:
> >> > From: Vladimir Oltean <vladimir.oltean@....com>
> >> >
> >> > There are 2 goals that we follow:
> >> >
> >> > - Reduce the header size
> >> > - Make the header size equal between RX and TX
> >>
> >> Getting this from sparse:
> >>
> >> ../net/dsa/tag_ocelot.c:185:17: warning: incorrect type in assignment (different base types)
> >> ../net/dsa/tag_ocelot.c:185:17:    expected unsigned int [usertype]
> >> ../net/dsa/tag_ocelot.c:185:17:    got restricted __be32 [usertype]
> >
> > I hate this warning :(
>
> You hate that endianness bugs are caught automatically? :-)
>

Well, there's no bug here, really, what's annoying is that it's
warning me when a convention is not being followed. It would have been
smarter if it just limited itself to the situations when not following
that convention actually causes a problem.