netdev - Re: [RFC PATCH net] net: flow_offload: simplify hw stats check handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc715ede-ce75-39ca-4887-4c1d208b4c1f@solarflare.com>
Date:   Mon, 11 May 2020 11:09:44 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Jiri Pirko <jiri@...nulli.us>, Jakub Kicinski <kuba@...nel.org>
CC:     Pablo Neira Ayuso <pablo@...filter.org>, <netdev@...r.kernel.org>,
        <davem@...emloft.net>, <netfilter-devel@...r.kernel.org>
Subject: Re: [RFC PATCH net] net: flow_offload: simplify hw stats check
 handling

On 11/05/2020 06:33, Jiri Pirko wrote:
> Fri, May 08, 2020 at 01:48:20AM CEST, kuba@...nel.org wrote:
>> On Thu, 7 May 2020 18:46:43 +0200 Pablo Neira Ayuso wrote:
>>> Jiri said Disabled means: bail out if you cannot disable it.
>> That's in TC uAPI Jiri chose... doesn't mean we have to do the same
>> internally.
> Yeah, but if TC user says "disabled", please don't assign counter or
> fail.
Right, that's what happens with my proposal: TC "disabled" gets
 mapped to internal "disabled (and no other bits)", which means
 "disable or fail".  In exactly the same way that TC "immediate"
 gets mapped to internal "immediate (and no other bits)" which
 means "immediate or fail".
As Jakub says, "What could be simpler?"

-ed