lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 May 2020 19:47:05 -0700 From: Jakub Kicinski <kuba@...nel.org> To: tanhuazhong <tanhuazhong@...wei.com> Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>, <linuxarm@...wei.com> Subject: Re: [PATCH net-next 3/5] net: hns3: provide .get_cmdq_stat interface for the client On Mon, 11 May 2020 08:13:06 +0800 tanhuazhong wrote: > On 2020/5/10 4:48, Jakub Kicinski wrote: > > On Sat, 9 May 2020 17:27:39 +0800 Huazhong Tan wrote: > >> diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h b/drivers/net/ethernet/hisilicon/hns3/hnae3.h > >> index 5602bf2..7506cab 100644 > >> --- a/drivers/net/ethernet/hisilicon/hns3/hnae3.h > >> +++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.h > >> @@ -552,6 +552,7 @@ struct hnae3_ae_ops { > >> int (*set_vf_mac)(struct hnae3_handle *handle, int vf, u8 *p); > >> int (*get_module_eeprom)(struct hnae3_handle *handle, u32 offset, > >> u32 len, u8 *data); > >> + bool (*get_cmdq_stat)(struct hnae3_handle *handle); > >> }; > > > > I don't see anything in this series using this new interface, why is it > > added now? > > This interface is needed by the roce client, whose patch will be > upstreamed to the rdma tree, it is other branch. So we provide this > interface previously, then the rdma guy will upstream their patch later, > maybe linux-5.8-rc*. Understood. Please make sure to include this kind of information in the cover letter in the future.
Powered by blists - more mailing lists