netdev - Re: pull request: bluetooth-next 2020-05-09

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 May 2020 12:20:10 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-bluetooth@...r.kernel.org
Subject: Re: pull request: bluetooth-next 2020-05-09

Hi Jakub,

>> Here's another set of Bluetooth patches for the 5.8 kernel:
>> 
>> - Add support for Intel Typhoon Peak device (8087:0032)
>> - Add device tree bindings for Realtek RTL8723BS device
>> - Add device tree bindings for Qualcomm QCA9377 device
>> - Add support for experimental features configuration through mgmt
>> - Multiple fixes & cleanups to the btbcm driver
>> - Add support for LE scatternet topology for selected devices
>> - A few other smaller fixes & cleanups
>> 
>> Please let me know if there are any issues pulling. Thanks.
> 
> Is your tree immutable, is there a chance you could still get the missing sign-off?
> 
> Commit bf1f79470a62 ("Bluetooth: btusb: Add support for Intel Bluetooth Device Typhoon Peak (8087:0032)")
> 	author Signed-off-by missing
> 	author email:    raghuram.hegde@...el.com
> 	committer email: marcel@...tmann.org
> 	Signed-off-by: Amit K Bag <amit.k.bag@...el.com>
> 	Signed-off-by: Tumkur Narayan, Chethan <chethan.tumkur.narayan@...el.com>
> 	Signed-off-by: Marcel Holtmann <marcel@...tmann.org>
> 
> Also, in the same patch:
> 
> ---------------------------------------------------------------
> 0015-Bluetooth-btusb-Add-support-for-Intel-Bluetooth-Devi.patch
> ---------------------------------------------------------------
> ERROR: code indent should use tabs where possible
> #55: FILE: drivers/bluetooth/btusb.c:346:
> +                                                     BTUSB_WIDEBAND_SPEECH},$
> 
> WARNING: please, no spaces at the start of a line
> #55: FILE: drivers/bluetooth/btusb.c:346:
> +                                                     BTUSB_WIDEBAND_SPEECH},$
> 
> WARNING: Missing Signed-off-by: line by nominal patch author '"Hegde, Raghuram" <raghuram.hegde@...el.com>'
> 
> total: 1 errors, 2 warnings, 0 checks, 8 lines checked

I took this patch out. They should fix it up and re-submit it.

> 
> 
> And:
> 
> ------------------------------------------------------------
> 0016-dt-bindings-net-bluetooth-Add-rtl8723bs-bluetooth.patch
> ------------------------------------------------------------
> WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)
> #23: FILE: Documentation/devicetree/bindings/net/realtek-bluetooth.yaml:1:
> +# SPDX-License-Identifier: GPL-2.0
> 
> total: 0 errors, 2 warnings, 0 checks, 54 lines checked

I try to get this fixed, but it might have to come in a subsequent pull request.

> 
> ---------------------------------------------------------------
> 0026-Bluetooth-Introduce-debug-feature-when-dynamic-debug.patch
> ---------------------------------------------------------------
> WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...
> #99: FILE: net/bluetooth/lib.c:212:
> +	printk(KERN_DEBUG pr_fmt("%pV"), &vaf);

This one is on purpose and has to be printk.

> WARNING: Missing a blank line after declarations
> #135: FILE: net/bluetooth/mgmt.c:3740:
> +		u32 flags = bt_dbg_get() ? BIT(0) : 0;
> +		memcpy(rp->features[idx].uuid, debug_uuid, 16);
> 
> WARNING: Missing a blank line after declarations
> #173: FILE: net/bluetooth/mgmt.c:3788:
> +			bool changed = bt_dbg_get();
> +			bt_dbg_set(false);

These two were on purpose, but while at it, I fixed them up.

> WARNING: 'Paramters' may be misspelled - perhaps 'Parameters'?
> #197: FILE: net/bluetooth/mgmt.c:3812:
> +		/* Paramters are limited to a single octet */

This was a dumb spelling mistake and I fixed it up.

Thanks for checking everything. I think Johan will just send a new pull request.

Regards

Marcel