netdev - Re: [PATCH net-next 2/8] sfc: make capability checking a nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05438101-2706-e791-abd3-e52694fdfe9c@solarflare.com>
Date:   Tue, 12 May 2020 14:01:24 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/8] sfc: make capability checking a nic_type
 function

On 11/05/2020 23:36, Jakub Kicinski wrote:
> Also with W=1:
>
>  ../drivers/net/ethernet/sfc/siena.c:951:14: warning: symbol 'siena_check_caps' was not declared. Should it be static?
> 1a3,5
>  ../drivers/net/ethernet/sfc/siena.c:951:14: warning: no previous prototype for â€˜siena_check_capsâ€™ [-Wmissing-prototypes]
>    951 | unsigned int siena_check_caps(const struct efx_nic *efx,
>        |              ^~~~~~~~~~~~~~~~
Yup, it turns out not only is this missing 'static' but it's also not
 used — the assignment into siena_a0_nic_typeis missing, I must have
 screwed up a rebase at some point.  I'll send a follow-up, since Dave
 has already applied it.  Thanks for the review.

(And I'll try to get in the habit of checking the SOBs better; sorry
 about that.  I'm still used to the old "first sign-off is the point
 of exit from the company" flow; plus I messed up my checkpatch
 invocation in a way that prevented it catching this.)

-ed