netdev - Re: [MPTCP] [PATCH net] mptcp: Initialize map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200512.120911.2258216308785425487.davem@davemloft.net>
Date:   Tue, 12 May 2020 12:09:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     cpaasch@...le.com, kuba@...nel.org, netdev@...r.kernel.org,
        mptcp@...ts.01.org
Subject: Re: [MPTCP] [PATCH net] mptcp: Initialize map_seq upon subflow
 establishment

From: Paolo Abeni <pabeni@...hat.com>
Date: Mon, 11 May 2020 19:35:21 +0200

> On Mon, 2020-05-11 at 09:24 -0700, Christoph Paasch wrote:
>> When the other MPTCP-peer uses 32-bit data-sequence numbers, we rely on
>> map_seq to indicate how to expand to a 64-bit data-sequence number in
>> expand_seq() when receiving data.
>> 
>> For new subflows, this field is not initialized, thus results in an
>> "invalid" mapping being discarded.
>> 
>> Fix this by initializing map_seq upon subflow establishment time.
>> 
>> Fixes: f296234c98a8 ("mptcp: Add handling of incoming MP_JOIN requests")
>> Signed-off-by: Christoph Paasch <cpaasch@...le.com>
 ...
> Reviewed-by: Paolo Abeni <pabeni@...hat.com>

Applied, thanks.