lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 May 2020 20:16:15 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Doug Berger <opendmb@...il.com>, "David S. Miller" <davem@...emloft.net> Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting On 5/11/2020 5:24 PM, Doug Berger wrote: > A comment in uapi/linux/ethtool.h states "Drivers should reject a > non-zero setting of @autoneg when autoneogotiation is disabled (or > not supported) for the link". > > That check should be added to phy_validate_pause() to consolidate > the code where possible. > > Fixes: 22b7d29926b5 ("net: ethernet: Add helper to determine if pause configuration is supported") > Signed-off-by: Doug Berger <opendmb@...il.com> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists