lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 11 May 2020 20:32:15 -0700
From:   Florian Fainelli <>
To:     Vladimir Oltean <>,,
Subject: Re: [PATCH v2 net-next 07/15] net: dsa: sja1105: exit
 sja1105_vlan_filtering when called multiple times

On 5/11/2020 6:53 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <>
> VLAN filtering is a global property for sja1105, and that means that we
> rely on the DSA core to not call us more than once.
> But we need to introduce some per-port state for the tagger, namely the
> xmit_tpid, and the best place to do that is where the xmit_tpid changes,
> namely in sja1105_vlan_filtering. So at the moment, exit early from the
> function to avoid unnecessarily resetting the switch for each port call.
> Then we'll change the xmit_tpid prior to the early exit in the next
> patch.
> Signed-off-by: Vladimir Oltean <>

Reviewed-by: Florian Fainelli <>

Powered by blists - more mailing lists