[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200513215441.22653800@canb.auug.org.au>
Date: Wed, 13 May 2020 21:54:41 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
Cc: kuba@...nel.org, Amol Grover <frextrite@...il.com>,
"David S . Miller" <davem@...emloft.net>,
Alexey Kuznetsov <kuznet@....inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-kernel-mentees@...ts.linuxfoundation.org,
Joel Fernandes <joel@...lfernandes.org>,
"Paul E . McKenney" <paulmck@...nel.org>
Subject: Re: [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to
ipmr_for_each_table macro
Hi all,
On Tue, 12 May 2020 10:47:05 +0530 Madhuparna Bhowmik <madhuparnabhowmik10@...il.com> wrote:
> >
> > I think what is happening is this:
> >
> > ipmr_net_init() -> ipmr_rules_init() -> ipmr_new_table()
> >
> > ipmr_new_table() returns an existing table if there is one, but
> > obviously none can exist at init. So a better fix would be:
> >
> > #define ipmr_for_each_table(mrt, net) \
> > list_for_each_entry_rcu(mrt, &net->ipv4.mr_tables, list, \
> > lockdep_rtnl_is_held() || \
> > list_empty(&net->ipv4.mr_tables))
> >
> (adding Stephen)
I have changed the patch in my fixes tree to this.
--
Cheers,
Stephen Rothwell
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists