[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2c9a28f7-4268-2295-0d64-ada9178a5553@grimberg.me>
Date: Wed, 13 May 2020 11:45:39 -0700
From: Sagi Grimberg <sagi@...mberg.me>
To: Christoph Hellwig <hch@....de>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
Eric Dumazet <edumazet@...gle.com>,
linux-nvme@...ts.infradead.org, linux-sctp@...r.kernel.org,
target-devel@...r.kernel.org, linux-afs@...ts.infradead.org,
drbd-dev@...ts.linbit.com, linux-cifs@...r.kernel.org,
rds-devel@....oracle.com, linux-rdma@...r.kernel.org,
cluster-devel@...hat.com, Alexey Kuznetsov <kuznet@....inr.ac.ru>,
linux-block@...r.kernel.org, ceph-devel@...r.kernel.org,
linux-nfs@...r.kernel.org, Neil Horman <nhorman@...driver.com>,
Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
netdev@...r.kernel.org, Vlad Yasevich <vyasevich@...il.com>,
linux-kernel@...r.kernel.org, Jon Maloy <jmaloy@...hat.com>,
Ying Xue <ying.xue@...driver.com>, ocfs2-devel@....oracle.com
Subject: Re: remove kernel_setsockopt and kernel_getsockopt
> Hi Dave,
>
> this series removes the kernel_setsockopt and kernel_getsockopt
> functions, and instead switches their users to small functions that
> implement setting (or in one case getting) a sockopt directly using
> a normal kernel function call with type safety and all the other
> benefits of not having a function call.
>
> In some cases these functions seem pretty heavy handed as they do
> a lock_sock even for just setting a single variable, but this mirrors
> the real setsockopt implementation - counter to that a few kernel
> drivers just set the fields directly already.
>
> Nevertheless the diffstat looks quite promising:
>
> 42 files changed, 721 insertions(+), 799 deletions(-)
For the nvme-tcp bits,
Acked-by: Sagi Grimberg <sagi@...mberg.me>
Powered by blists - more mailing lists