netdev - Re: [PATCH net] net: phy: fix aneg restart in phy_ethtool_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200513.152310.1761379266532416158.davem@davemloft.net>
Date:   Wed, 13 May 2020 15:23:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, linux@...linux.org.uk,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: phy: fix aneg restart in phy_ethtool_set_eee

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 12 May 2020 21:45:53 +0200

> phy_restart_aneg() enables aneg in the PHY. That's not what we want
> if phydev->autoneg is disabled. In this case still update EEE
> advertisement register, but don't enable aneg and don't trigger an
> aneg restart.
> 
> Fixes: f75abeb8338e ("net: phy: restart phy autonegotiation after EEE advertisment change")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for -stable, thanks.