netdev - Re: [PATCH net-next] net: dsa: mt7530: set CPU port to fallback mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200513.152501.2023097002346051384.davem@davemloft.net>
Date:   Wed, 13 May 2020 15:25:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dqfext@...il.com
Cc:     netdev@...r.kernel.org, sean.wang@...iatek.com, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        linux-mediatek@...ts.infradead.org, linux@...linux.org.uk,
        matthias.bgg@...il.com, opensource@...rst.com, tj17@...com,
        foss@...atilesystems.org, riddlariddla@...mail.com,
        szab.hu@...il.com, fercerpav@...il.com
Subject: Re: [PATCH net-next] net: dsa: mt7530: set CPU port to fallback
 mode

From: DENG Qingfang <dqfext@...il.com>
Date: Wed, 13 May 2020 23:37:17 +0800

> Currently, setting a bridge's self PVID to other value and deleting
> the default VID 1 renders untagged ports of that VLAN unable to talk to
> the CPU port:
> 
> 	bridge vlan add dev br0 vid 2 pvid untagged self
> 	bridge vlan del dev br0 vid 1 self
> 	bridge vlan add dev sw0p0 vid 2 pvid untagged
> 	bridge vlan del dev sw0p0 vid 1
> 	# br0 cannot send untagged frames out of sw0p0 anymore
> 
> That is because the CPU port is set to security mode and its PVID is
> still 1, and untagged frames are dropped due to VLAN member violation.
> 
> Set the CPU port to fallback mode so untagged frames can pass through.
> 
> Fixes: 83163f7dca56 ("net: dsa: mediatek: add VLAN support for MT7530")
> Signed-off-by: DENG Qingfang <dqfext@...il.com>

Applied to net-next, thanks.