netdev - Re: [PATCH net-next] net: dsa: tag_sja1105: appease sparse checks for ethertype accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200512.180254.1087908389957071261.davem@redhat.com>
Date:   Tue, 12 May 2020 18:02:54 -0700 (PDT)
From:   David Miller <davem@...hat.com>
To:     olteanv@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: tag_sja1105: appease sparse checks
 for ethertype accessors

From: Vladimir Oltean <olteanv@...il.com>
Date: Wed, 13 May 2020 03:23:27 +0300

> A comparison between a value from the packet and an integer constant
> value needs to be done by converting the value from the packet from
> net->host, or the constant from host->net. Not the other way around.
> Even though it makes no practical difference, correct that.
> 
> Fixes: 38b5beeae7a4 ("net: dsa: sja1105: prepare tagger for handling DSA tags and VLAN simultaneously")
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Applied.