netdev - Re: [PATCH ipsec-next] xfrm: fix unused variable warning if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 May 2020 06:42:36 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Florian Westphal <fw@...len.de>
CC:     <netdev@...r.kernel.org>, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH ipsec-next] xfrm: fix unused variable warning if
 CONFIG_NETFILTER=n

On Mon, May 11, 2020 at 10:33:42AM +0200, Florian Westphal wrote:
> After recent change 'x' is only used when CONFIG_NETFILTER is set:
> 
> net/ipv4/xfrm4_output.c: In function '__xfrm4_output':
> net/ipv4/xfrm4_output.c:19:21: warning: unused variable 'x' [-Wunused-variable]
>    19 |  struct xfrm_state *x = skb_dst(skb)->xfrm;
> 
> Expand the CONFIG_NETFILTER scope to avoid this.
> 
> Fixes: 2ab6096db2f1 ("xfrm: remove output_finish indirection from xfrm_state_afinfo")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks Florian!