netdev - Re: [PATCH V5 18/19] net: ks8851: Implement Parallel bus operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab77de0e-add6-4f87-d82d-6c5166b7b648@denx.de>
Date:   Thu, 14 May 2020 16:33:52 +0200
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Lukas Wunner <lukas@...ner.de>, Petr Stetiar <ynezz@...e.cz>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH V5 18/19] net: ks8851: Implement Parallel bus operations

On 5/14/20 4:22 PM, Andrew Lunn wrote:
> On Thu, May 14, 2020 at 04:14:13PM +0200, Marek Vasut wrote:
>> On 5/14/20 4:07 PM, Andrew Lunn wrote:
>>>> All right
>>>>
>>>> btw is jiffies-based timeout OK? Like this:
>>>
>>> If you can, make use of include/linux/iopoll.h
>>
>> I can't, because I need those weird custom accessors, see
>> ks8851_wrreg16_par(), unless I'm missing something there?
> 
> static int ks8851_rdreg16_par_txqcr(struct foo ks) {
>        return ks8851_rdreg16_par(ks, KS_TXQCR)
> }
> 
> int txqcr;
> 
> err = readx_poll_timeout(ks8851_rdreg16_par_txqcr, txqcr,
>                          txqcr & TXQCR_METFE, 10, 10, ks)
> 

OK