netdev - Re: [PATCH V5 14/19] net: ks8851: Factor out TX work flush function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200514013306.GI527401@lunn.ch>
Date:   Thu, 14 May 2020 03:33:06 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Lukas Wunner <lukas@...ner.de>, Petr Stetiar <ynezz@...e.cz>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH V5 14/19] net: ks8851: Factor out TX work flush function

On Thu, May 14, 2020 at 02:07:42AM +0200, Marek Vasut wrote:
> While the SPI version of the KS8851 requires a TX worker thread to pump
> data via SPI, the parallel bus version can write data into the TX FIFO
> directly in .ndo_start_xmit, as the parallel bus access is much faster
> and does not sleep. Factor out this TX work flush part, so it can be
> overridden by the parallel bus driver.
> 
> Signed-off-by: Marek Vasut <marex@...x.de>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Lukas Wunner <lukas@...ner.de>
> Cc: Petr Stetiar <ynezz@...e.cz>
> Cc: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew