netdev - Re: [PATCH RESEND net-next] selftests: fix flower parent qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200514.124954.1909205796405577142.davem@davemloft.net>
Date:   Thu, 14 May 2020 12:49:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vladbu@...lanox.com
Cc:     linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
        shuah@...nel.org, xiyou.wangcong@...il.com, jhs@...atatu.com,
        dcaratti@...hat.com, marcelo.leitner@...il.com
Subject: Re: [PATCH RESEND net-next] selftests: fix flower parent qdisc

From: Vlad Buslov <vladbu@...lanox.com>
Date: Thu, 14 May 2020 09:35:52 +0300

> Flower tests used to create ingress filter with specified parent qdisc
> "parent ffff:" but dump them on "ingress". With recent commit that fixed
> tcm_parent handling in dump those are not considered same parent anymore,
> which causes iproute2 tc to emit additional "parent ffff:" in first line of
> filter dump output. The change in output causes filter match in tests to
> fail.
> 
> Prevent parent qdisc output when dumping filters in flower tests by always
> correctly specifying "ingress" parent both when creating and dumping
> filters.
> 
> Fixes: a7df4870d79b ("net_sched: fix tcm_parent in tc filter dump")
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Applied, thanks.