lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 14 May 2020 12:56:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     brgl@...ev.pl
Cc:     corbet@....net, robh+dt@...nel.org, matthias.bgg@...il.com,
        john@...ozen.org, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
        kuba@...nel.org, arnd@...db.de, fparent@...libre.com,
        hkallweit1@...il.com, edwin.peer@...adcom.com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        stephane.leprovost@...iatek.com, pedro.tsai@...iatek.com,
        andrew.perepech@...iatek.com, bgolaszewski@...libre.com
Subject: Re: [PATCH v3 00/15] mediatek: add support for MediaTek Ethernet
 MAC

From: Bartosz Golaszewski <brgl@...ev.pl>
Date: Thu, 14 May 2020 09:59:27 +0200

> Next we do some cleanup of the mediatek ethernet drivers directory and update
> the devres documentation with existing networking devres helpers.

I don't agree with the new devres stuff.

You have to be very careful with the ordering of when you map/unmap
registers, free up anciliary resources, etc. in relationship to when
the netdev unregister happens.

Please submit this driver without these controversial devres changes,
and then you can submit and discuss those changes separately later.

Thanks.

Powered by blists - more mailing lists