netdev - Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200514.130952.794606246311304590.davem@davemloft.net>
Date:   Thu, 14 May 2020 13:09:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     irusskikh@...vell.com
Cc:     netdev@...r.kernel.org, aelior@...vell.com, mkalderon@...vell.com,
        dbolotin@...vell.com, kuba@...nel.org
Subject: Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error
 handling

From: David Miller <davem@...emloft.net>
Date: Thu, 14 May 2020 13:01:59 -0700 (PDT)

> From: Igor Russkikh <irusskikh@...vell.com>
> Date: Thu, 14 May 2020 12:57:16 +0300
> 
>> FastLinQ devices as a complex systems may observe various hardware
>> level error conditions, both severe and recoverable.
>> 
>> Driver is able to detect and report this, but so far it only did
>> trace/dmesg based reporting.
>> 
>> Here we implement an extended hw error detection, service task
>> handler captures a dump for the later analysis.
>> 
>> I also resubmit a patch from Denis Bolotin on tx timeout handler,
>> addressing David's comment regarding recovery procedure as an extra
>> reaction on this event.
>> 
>> v2:
>> 
>> Removing the patch with ethtool dump and udev magic. Its quite isolated,
>> I'm working on devlink based logic for this separately.
>> 
>> v1:
>> 
>> https://patchwork.ozlabs.org/project/netdev/cover/cover.1588758463.git.irusskikh@marvell.com/
> 
> I'm only applying this series because I trust that you will actually do the
> devlink work, and you will have it done and submitted in a reasonable amount
> of ti me.
> 
> Also, patch #4 had trailing empty lines added to a file, which is
> warned about by 'git' when I apply your patches.  I fixed it up, but
> this is the kind of thing you should have sorted out before you submit
> changes to the list.

Actually, I had to revert, please fix these warnings (with gcc-10.1.1 on Fedora)_:

drivers/net/ethernet/qlogic/qed/qed_dev.c: In function ‘qed_llh_add_mac_filter’:
./include/linux/printk.h:303:2: warning: ‘abs_ppfid’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  303 |  printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
      |  ^~~~~~
drivers/net/ethernet/qlogic/qed/qed_dev.c:983:17: note: ‘abs_ppfid’ was declared here
  983 |  u8 filter_idx, abs_ppfid;
      |                 ^~~~~~~~~