netdev - Re: [net-next v2 3/9] igc: add support to eeprom, registers and link self-tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200514.150750.17841471129931986.davem@davemloft.net>
Date:   Thu, 14 May 2020 15:07:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuba@...nel.org
Cc:     jeffrey.t.kirsher@...el.com, vitaly.lifshits@...el.com,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        lkp@...el.com, dan.carpenter@...cle.com, aaron.f.brown@...el.com
Subject: Re: [net-next v2 3/9] igc: add support to eeprom, registers and
 link self-tests

From: Jakub Kicinski <kuba@...nel.org>
Date: Thu, 14 May 2020 14:52:19 -0700

> On Thu, 14 May 2020 14:31:11 -0700 Jeff Kirsher wrote:
>> diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c b/drivers/net/ethernet/intel/igc/igc_diag.c
>> new file mode 100644
>> index 000000000000..1c4536105e56
>> --- /dev/null
>> +++ b/drivers/net/ethernet/intel/igc/igc_diag.c
>> @@ -0,0 +1,186 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/* Copyright (c)  2020 Intel Corporation */
>> +
>> +#include "igc.h"
>> +#include "igc_diag.h"
>> +
>> +struct igc_reg_test reg_test[] = {
>> +	{ IGC_FCAL,	1,	PATTERN_TEST,	0xFFFFFFFF,	0xFFFFFFFF },
>> +	{ IGC_FCAH,	1,	PATTERN_TEST,	0x0000FFFF,	0xFFFFFFFF },
>> +	{ IGC_FCT,	1,	PATTERN_TEST,	0x0000FFFF,	0xFFFFFFFF },
>> +	{ IGC_RDBAH(0), 4,	PATTERN_TEST,	0xFFFFFFFF,	0xFFFFFFFF },
> 
> drivers/net/ethernet/intel/igc/igc_diag.c:7:21: warning: symbol 'reg_test' was not declared. Should it be static?

Jeff, you might want to start checking this kind of stuff internally
since Jakub is going to catch it within minutes of you posting your
changes :-)))