[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200514070409.GA3174@madhuparna-HP-Notebook>
Date: Thu, 14 May 2020 12:34:09 +0530
From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
To: David Miller <davem@...emloft.net>
Cc: madhuparnabhowmik10@...il.com, kuznet@....inr.ac.ru,
yoshfuji@...ux-ipv6.org, kuba@...nel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, sfr@...b.auug.org.au,
frextrite@...il.com, joel@...lfernandes.org, paulmck@...nel.org,
cai@....pw
Subject: Re: [PATCH] Fix suspicious RCU usage warning
On Wed, May 13, 2020 at 12:00:10PM -0700, David Miller wrote:
> From: madhuparnabhowmik10@...il.com
> Date: Wed, 13 May 2020 11:46:10 +0530
>
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> >
> > This patch fixes the following warning:
> >
> > =============================
> > WARNING: suspicious RCU usage
> > 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted
> > -----------------------------
> > net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
> >
> > ipmr_new_table() returns an existing table, but there is no table at
> > init. Therefore the condition: either holding rtnl or the list is empty
> > is used.
> >
> > Suggested-by: Jakub Kicinski <kuba@...nel.org>
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> >
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
>
> Please only provide one signoff line.
>
> Please provide a proper Fixes: tag for this bug fix.
>
> And finally, please make your Subject line more appropriate. It must
> first state the target tree inside of the "[PATCH]" area, the two choices
> are "[PATCH net]" and "[PATCH net-next]" and it depends upon which tree
> this patch is targetting.
>
> Then your Subject line should also be more descriptive about exactly the
> subsystem and area the change is being made to, for this change for
> example you could use something like:
>
> ipv6: Fix suspicious RCU usage warning in ip6mr.
>
> Also, obviously, there are also syzkaller tags you can add to the
> commit message as well.
Sorry for this malformed patch, I have sent a patch with all these
corrections.
Thank you,
Madhuparna
Powered by blists - more mailing lists