netdev - Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <128700.1589555724@warthog.procyon.org.uk>
Date:   Fri, 15 May 2020 16:15:24 +0100
From:   David Howells <dhowells@...hat.com>
To:     Christoph Hellwig <hch@....de>
Cc:     dhowells@...hat.com, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        linux-nvme@...ts.infradead.org, linux-sctp@...r.kernel.org,
        target-devel@...r.kernel.org, linux-afs@...ts.infradead.org,
        drbd-dev@...ts.linbit.com, linux-cifs@...r.kernel.org,
        rds-devel@....oracle.com, linux-rdma@...r.kernel.org,
        cluster-devel@...hat.com, Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        linux-block@...r.kernel.org, ceph-devel@...r.kernel.org,
        linux-nfs@...r.kernel.org, Neil Horman <nhorman@...driver.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        netdev@...r.kernel.org, Vlad Yasevich <vyasevich@...il.com>,
        linux-kernel@...r.kernel.org, Jon Maloy <jmaloy@...hat.com>,
        Ying Xue <ying.xue@...driver.com>, ocfs2-devel@....oracle.com
Subject: Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover

Christoph Hellwig <hch@....de> wrote:

> > > +		ip_sock_set_mtu_discover(conn->params.local->socket->sk,
> > > +				IP_PMTUDISC_DONT);
> > 
> > Um... The socket in question could be an AF_INET6 socket, not an AF_INET4
> > socket - I presume it will work in that case.  If so:
> 
> Yes, the implementation of that sockopt, including the inet_sock
> structure where these options are set is shared between ipv4 and ipv6.

Great!  Could you note that either in the patch description or in the
kerneldoc attached to the function?

Thanks,
David