netdev - Re: [PATCH net] net: phy: broadcom: add support for BCM54811 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2f12255-83a6-9de2-c82f-ebdc6b0352f2@gmail.com>
Date:   Fri, 15 May 2020 08:53:37 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Kevin Lo <kevlo@...lo.org>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] net: phy: broadcom: add support for BCM54811 PHY



On 5/14/2020 10:22 PM, Kevin Lo wrote:
> The BCM54811 PHY shares many similarities with the already supported BCM54810
> PHY but additionally requires some semi-unique configuration.

This looks mostly fine, just a couple of nits:

- the patch should be submitted against net-next, since it is a new
feature/addition and not a bug fix

- you need an additional entry to support the automatic loading of the
PHY driver, that means adding an entry to the  broadcom_tbl array.

With that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian