netdev - Re: [PATCH net-next] net: core: recursively find netdev by device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8489eb0e-136e-bd91-a4a0-a551d4126339@gmail.com>
Date:   Fri, 15 May 2020 09:00:02 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Tobias Waldekranz <tobias@...dekranz.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, andrew@...n.ch
Subject: Re: [PATCH net-next] net: core: recursively find netdev by device
 node



On 5/15/2020 2:52 AM, Tobias Waldekranz wrote:
> The assumption that a device node is associated either with the
> netdev's device, or the parent of that device, does not hold for all
> drivers. E.g. Freescale's DPAA has two layers of platform devices
> above the netdev. Instead, recursively walk up the tree from the
> netdev, allowing any parent to match against the sought after node.
> 
> Signed-off-by: Tobias Waldekranz <tobias@...dekranz.com>

Humm, yes I tried to solve this differently before within the Freescale
FMAN driver before and it failed miserably, so I suppose this is as good
as it can be:

a1a50c8e4c241a505b7270e1a3c6e50d94e794b1 ("fsl/man: Inherit parent
device and of_node") later reverted with
48167c9ce0b91c068430345bf039c7be23fa2f3f ("fsl/fman: remove of_node")

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian